Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for new docker sdk (quick fix) #764

Merged
merged 2 commits into from
Mar 12, 2017
Merged

Conversation

kireledan
Copy link
Contributor

In regards to #743

This is a quick fix to alleviate the issue with the SDK changes. I can spend more time to utilize the abstraction layer built on top of the 'low-level API' if desired.

@retr0h
Copy link
Contributor

retr0h commented Mar 11, 2017

Thanks @kireledan.

Can we update test-requirements.txt with the new pinning of docker-2.1.0? We also need to update doc/source/driver/docker/index.rst, doc/source/driver/docker/usage.rst, qmolecule/driver/dockerdriver.py, and README.rstwithdockerinstead ofdocker-py`.

@retr0h
Copy link
Contributor

retr0h commented Mar 11, 2017

Once the above is addressed, this commit looks good.

> Also corrected links / errors printed
@kireledan
Copy link
Contributor Author

I tried to make the error message as clear as I could. Just saying to install docker could be a bit confusing.

@retr0h retr0h merged commit a6fda66 into ansible:master Mar 12, 2017
@retr0h retr0h added the v1.21 label Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants